Lemmy maintainer

  • 23 Posts
  • 175 Comments
Joined 5 years ago
cake
Cake day: January 17th, 2020

help-circle











  • Im a former contributor to F-Droid with various merged pull requests. Looking at the indicated pull request I really doubt that it was an intentional attack. First of all its easy to forget for a new developer to escape SQL parameters, and the docs dont even mention a risk of SQL injection attacks. And of the users pushing for the PR to be merged, one is a long-time F-Droid contributor, and the other also looks like a real human with many contributions in other repos, so no sockpuppets in sight.

    It simply looks like standard open source behaviour, for better or for worse. A new user makes a contribution for a highly demanded feature, and users want it to get merged as soon as possible. Maintainers are discussing the big picture of the change and want to avoid breaking changes, without getting into code review yet. The new contributor seems unwilling to make any design changes to his PR, and gets frustrated that it doesnt get merged as is. The potential vulnerability is only noticed half a year after the PR was opened, at which point it was already de facto abandoned. So not an attack, but simply a developer who is new to open source and doesnt understand how the process works.



  • The automatic language tag should only depend on the community language settings and user language settings. Specifically it will build the intersection of both, and if the result only contains one item (excluding “undetermined”), that is used as the post language. The instance doesnt matter at all. And there havent been any changes in this area in a while, so there should be no difference between 0.19.x versions.

    I thought maybe the community language isnt federated properly but its identical on all mentioned instances. Also @Camus@sh.itjust.works mentioned that French is enabled in user settings. There is clearly a bug but I cant think what else might be causing it.

    Anyway please report such bugs directly on the issue tracker, otherwise I might not find out about it at all.